-
Notifications
You must be signed in to change notification settings - Fork 6
WIP - DO NOT MERGE - Documentation overhaul #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for this - has this been done in conjunction with @rasummer ? |
|
The idea was that I am creating a first draft and afterwards he does a review @rasummer: Can you please do a review of the styling? @huntc: Would be also nice to get feedback about the styling from you and the team. The styling is IMO complete, but there are still some other topics missing which has been described in the ConductR documentation improvements doc:
Would like to work on these topics today. |
|
@markusjura @huntc I'll try to take a look today, if not then Tuesday. |
be12ee6 to
461166e
Compare
|
UPDATE
|
06dfc22 to
5abe2cd
Compare
|
@markusjura @huntc I've taken a look at the updates and they LGTM. Per our discussion Markus, here's the recommendation for a CSS fix for extra long words that cause html elements such as tables to break out of their containing columns. For example, the first table on the following page is wider than the containing column: http://conductr.typesafe.com/developer/Bundle-Env.html .wrap {
word-break: break-all;
}The documentation creator would add the class of 'wrap' to a parent element such as the |
|
Thanks for the feedback @rasummer ! @markusjura please note that this no longer merges. Also, I'm changing the title to note that this is still a WIP. Please change the title once you're ready for it to be merged. |
|
LGTM - merge at will. Awesome work! |
|
UPDATE
Attention Testing |
3fb0ac9 to
c8eb0c1
Compare
WIP - DO NOT MERGE - Documentation overhaul
Changed documentation styling:
codeandpre)psectionsrow-widthfrom 1200 to 1000 which results in the same row margin of62.5emas on typesafe.comwhite-dkrstyling towhite-ltr