Interpret a version from a ref

[huntc]

Use the ref field of a web hook to determine a version number. The web hook conveys which branch should be updated.

Fixed up a failing test also.

[markusjura]

Why do we need this ConductRDocRenderer?

[huntc]

Good question. We no longer need to do this. The mapping of versions to renderers should be localised to the Application. I will change this.

On 18 Sep 2015, at 7:06 am, Markus Jura notifications@github.com wrote:

In app/controllers/Application.scala:

   }

• }

•  .flatMap(_.get(pathVersion))
  

  }
  }

  class Application @Inject() (
  @nAmed("ConductRDocRenderer") conductrDocRenderer: ActorRef,
  Why do we need this ConductRDocRenderer?

—
Reply to this email directly or view it on GitHub.

[markusjura]

LGTM (beside comments which are only style related). Also tested it locally and it is working fine.

[huntc]

Great. I'll create a test for the webhook notification via the controller today in order to finish it off. Thanks.

On 18 Sep 2015, at 7:21 am, Markus Jura notifications@github.com wrote:

LGTM (beside comments which are only style related). Also tested it locally and it is working fine.

—
Reply to this email directly or view it on GitHub.

[markusjura]

LGTM