Skip to content

Fix rep giving false positives #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ckiee merged 2 commits into from
Oct 2, 2020
Merged

Fix rep giving false positives #89

ckiee merged 2 commits into from
Oct 2, 2020

Conversation

@robertt
Copy link
Member

@robertt robertt commented Oct 2, 2020

This PR adds a regex instead of the old contains method which had a lot of false positives.

@robertt robertt requested a review from ckiee October 2, 2020 18:36
ckiee
ckiee requested changes Oct 2, 2020
View reviewed changes
@ckiee ckiee merged commit 65dc3e5 into master Oct 2, 2020
@robertt robertt deleted the fix/fix-rep branch October 2, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckiee ckiee ckiee approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robertt @ckiee