Remove incorrect comment #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertt
approved these changes
Oct 4, 2020
Member
|
Although, they still do all have to be lowercase. |
ckiee
approved these changes
Oct 4, 2020
Contributor
Author
|
The RegEx in the code is case insensitive, see here |
Collaborator
It's ambiguous - the comment could have meant the words in the array that was there before needed to be all lowercase OR that the words in the messages we're filtering needed to be all lowercase. (although the former makes more sense) |
Member
|
I was referring to how the words in the regex need to be lowercase but after testing I realised they don't, merging 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes an incorrect comment regarding a RegEx in the code, which has the potential to mislead and confuse other people studying the code for their own learning purposes.
This comment was leftover from the old "thanks" check, but it doesn't belong there anymore.