Skip to content

Conversation

@sciborrudnicki
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the codebase to use types and interfaces from the external @typedly/middleware package instead of maintaining local definitions. The changes remove local type definitions and interface declarations, replacing internal imports with imports from the new peer dependency.

  • Removes local type definitions (MiddlewareFunction, ContextMiddlewareFunction) and interface (MiddlewareShape)
  • Updates all import statements to reference @typedly/middleware package
  • Adds @typedly/middleware as a peer dependency

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/type/middleware-function.type.ts Deleted local MiddlewareFunction type definition
src/type/context-middleware-function.type.ts Deleted local ContextMiddlewareFunction type definition
src/type/index.ts Removed exports for deleted local types
src/interface/middleware.shape.ts Deleted local MiddlewareShape interface definition
src/interface/index.ts Removed export for deleted local interface
src/public-api.ts Removed public exports of types and interfaces now provided by external package
src/lib/middleware.class.ts Updated import to use MiddlewareFunction from @typedly/middleware
src/lib/middleware-core.abstract.ts Updated import to use MiddlewareShape from @typedly/middleware
src/lib/middleware-base.abstract.ts Updated import to use MiddlewareFunction from @typedly/middleware
src/lib/context-middleware.class.ts Updated import to use ContextMiddlewareFunction from @typedly/middleware
src/lib/context-middleware-base.abstract.ts Updated import to use ContextMiddlewareFunction from @typedly/middleware
package.json Added @typedly/middleware as a peer dependency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@sciborrudnicki sciborrudnicki merged commit 8ea34ab into main Dec 1, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants