Ignore uneeded files for distribution#29
Merged
AbdullahFaqeir merged 1 commit intotypesense:masterfrom Apr 7, 2024
pH-7:patch-1
Merged
Ignore uneeded files for distribution#29AbdullahFaqeir merged 1 commit intotypesense:masterfrom pH-7:patch-1
AbdullahFaqeir merged 1 commit intotypesense:masterfrom
pH-7:patch-1
Conversation
A good idea is to exclude unneeded dev files from the final production zip archive file, which is also downloaded by composer (unless --prefer -source is specified). Those files are actually only useful when working on the library itself. If you are not familiar, further information about `export-ignore` can be found below for instance: * http://www.pixelite.co.nz/article/using-git-attributes-exclude-files-your-release/ * https://madewithlove.be/gitattributes/ I hope it helps! 😊
Contributor
Author
|
@karakhanyans Would you mind having a look? 🤔 |
Collaborator
|
@pH-7 We apologise for taking forever to review this PR, thank you for it, I went over the references you've mentioned and this actually is helpful, Thanks!. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
A good idea is to exclude unneeded dev files from the final production zip archive file, which is also downloaded by composer (unless
--prefer -sourceflag is specified).Those files are actually only useful when working on the library itself.
In case you are not familiar, further information about
export-ignorecan be found below for instance:I hope it helps @kishorenc / @AbdullahFaqeir 😊
PR Checklist