Skip to content

Added support for document updates and upserts [v4.1.0]#3

Merged
jasonbosco merged 6 commits intomasterfrom
document-updates-and-upserts
Oct 26, 2020
Merged

Added support for document updates and upserts [v4.1.0]#3
jasonbosco merged 6 commits intomasterfrom
document-updates-and-upserts

Conversation

@jasonbosco
Copy link
Copy Markdown
Member

Change Summary

Resolves #2

@jasonbosco jasonbosco added the enhancement New feature or request label Oct 23, 2020
@jasonbosco jasonbosco self-assigned this Oct 23, 2020
@jasonbosco
Copy link
Copy Markdown
Member Author

@AbdullahFaqeir Still working on adding some finishing touches to v0.16 of Typesense server, so this PR is not ready to release yet. But in the meantime, could you help review these code changes when you get a chance?

@jasonbosco jasonbosco changed the title Added support for document updates and upserts Added support for document updates and upserts [v4.1.0] Oct 23, 2020
@jasonbosco jasonbosco force-pushed the document-updates-and-upserts branch from 33a9ebd to ccee923 Compare October 25, 2020 00:39
@AbdullahFaqeir
Copy link
Copy Markdown
Collaborator

AbdullahFaqeir commented Oct 25, 2020

HI @jasonbosco

I'm sorry I didn't get time to review your php code, I'm really sorry.

Update: I just went over the updates you've made all seems good, and I just want to make sure that you ran the examples and everything went well, l guess I need to work on the laravel package before releasing the update for typesense 0.16.0 to make it compatible.

Comment thread src/ApiCall.php
Comment thread src/Documents.php
Comment thread src/Documents.php
Comment thread README.md
@jasonbosco
Copy link
Copy Markdown
Member Author

HI @jasonbosco

I'm sorry I didn't get time to review your php code, I'm really sorry.

Update: I just went over the updates you've made all seems good, and I just want to make sure that you ran the examples and everything went well, l guess I need to work on the laravel package before releasing the update for typesense 0.16.0 to make it compatible.

@AbdullahFaqeir No worries, thank you for reviewing the code. I've added my comments to the PR. The changes I've made here should be backward compatible with previous implementations since I've added default values to new method arguments and only added a deprecating warning log message to createMany. So we should be able to release the PHP library independently. But let me know if you see any other issues with backward incompatibility. The goal is to make this release backward compatible.

@AbdullahFaqeir
Copy link
Copy Markdown
Collaborator

HI @jasonbosco
I'm sorry I didn't get time to review your php code, I'm really sorry.
Update: I just went over the updates you've made all seems good, and I just want to make sure that you ran the examples and everything went well, l guess I need to work on the laravel package before releasing the update for typesense 0.16.0 to make it compatible.

@AbdullahFaqeir No worries, thank you for reviewing the code. I've added my comments to the PR. The changes I've made here should be backward compatible with previous implementations since I've added default values to new method arguments and only added a deprecating warning log message to createMany. So we should be able to release the PHP library independently. But let me know if you see any other issues with backward incompatibility. The goal is to make this release backward compatible.

@jasonbosco All is good, thanks mate.

Cheers,

@jasonbosco jasonbosco merged commit aae2588 into master Oct 26, 2020
@jasonbosco jasonbosco deleted the document-updates-and-upserts branch July 5, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for document upserts and updates

2 participants