Skip to content

Initialise Swift Client #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
programVeins merged 42 commits into from
Dec 16, 2021
Merged

Initialise Swift Client #1

programVeins merged 42 commits into from
Dec 16, 2021

Conversation

@programVeins
Copy link
Contributor

@programVeins programVeins commented Aug 17, 2021

Features

  • Add generated types from Typesense api spec using Swagger
  • Add API structs for Configuration and Client
  • Add Apicall API wrapper
  • Implement Apicall API with Request Types

@programVeins programVeins self-assigned this Aug 24, 2021
kishorenc
kishorenc requested changes Aug 27, 2021
View reviewed changes
Copy link
Member

@kishorenc kishorenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

performRequest also needs to implement logic around checking for response status codes. If you find the JS async style confusing to follow as reference, you can also refer to the Python code here: https://github.com/typesense/typesense-python/blob/master/typesense/api_call.py#L86

@programVeins
Copy link
Contributor Author

programVeins commented Oct 25, 2021 •
edited
Loading

Resolves #2

Code is now refactored with Async/Await thus eliminating the need for an asynchronous callback for numRetries, it simply works inside a for loop.

kishorenc
kishorenc requested changes Oct 25, 2021
View reviewed changes
@programVeins programVeins force-pushed the initialize-swift-client branch from 976ab08 to bef4fd8 Compare December 1, 2021 09:32
@programVeins programVeins changed the title Add Apicall Initialise Swift Client Dec 16, 2021
@programVeins
Copy link
Contributor Author

programVeins commented Dec 16, 2021

Features

  • Authentication of the client 🔐
  • Collections endpoint - CRUD features
  • Documents endpoint - CRUD features
  • Document Search with Parameters 🔎
  • Batch import documents from a .jsonl file

@programVeins programVeins merged commit 5805d86 into master Dec 16, 2021
@programVeins programVeins deleted the initialize-swift-client branch December 17, 2021 03:25
jasonbosco pushed a commit that referenced this pull request Aug 2, 2024
@haydenhoang
Merge pull request #1 from phiHero/ci
71dd41e 
Ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kishorenc kishorenc kishorenc requested changes

@jasonbosco jasonbosco Awaiting requested review from jasonbosco

Assignees

@programVeins programVeins

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@programVeins @kishorenc @jasonbosco