Avoid global state

[Strate]

As for me, having global state like this:

import "./SomeController" // import result affects as a global variable
let app = createExpressServer() // express server implicitly use "SomeController"

is not a good idea, because is handles like global variables. For example, this requries to clear metadata storage before each functional test. I think it could be better, if you made this opt-in, and add ability to explicit pass controllers, interceptors and other citizens to createExpressServer:

import SomeController from "./SomeController"
import SomeInterceptor from "./SomeInterceptor"
let app = createExpressServer(
  SomeController,
  SomeInterceptor
)

or somehow else. What do you think about it?

[pleerock]

I don't think its possible to avoid a global state when using decorators. So, in any cases decorators will register controllers in a global place. The only thing can be done, is to restrict controllers that needs to be registered in the express by providing a list of controllers implicitly, as you pointed out in the example.

Here I already have a method that will register only controllers from the list of given classes. But * classes* argument is not used yet, need to finish this part by sending a list of classes to registerController method here. Here importClassesFromDirectories should return a list of classes to be registered. These classes needs to be send to the registerController method and everything should work I guess. I hadn't time to finish this part, but it definitely can be done easily. Try to do it, if no I'll do it later when I get more free time.

[Strate]

Global state for decorators can be avoided, if metadata information will be stored inside class function (for example in $metadata or $reflection) property.
Thank you for that points, I'll check that.

[MichalLytek]

I like the way it's done in TypeORM:

const options: CreateConnectionOptions = {
    // ... other options
    entities: [Photo, PhotoMetadata, Author, Album]
};

It could be looking here like this:

let app = createExpressServer({
     controllers: [UserController, SampleController]
});

Now only dir with glob strings are supported:

let app = createExpressServer({
     controllers: [__dirname + "/../controllers/*.js"]
});

[pleerock]

@19majkel94 we can add this feature too I think

[Strate]

I suggest you to use Reflect to store metadata.

[pleerock]

Im going to close this. @19majkel94 specifying controllers will be supported in 0.7.0. Regarding to storing metadata - I'll left it as it is. No matter if its saved in exported variable or Reflect - it will be global in any cases.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.