Session problem with default error handler

[iH8c0ff33]

when using express-session the default error handler fails to write the request because the request is closed before any data is sent.

[MichalLytek]

I use express-session with routing-controllers with no problems.
Could you provide minimal sample of code to reproduce the error? Or describe the problem in more details 😉

[iH8c0ff33]

I will do that in a moment @19majkel94

[iH8c0ff33]

That's my session config:

app.use(express_session({
  secret: cookie_secret,
  // Don't store sessions that are not logged in
  saveUninitialized: true,
  resave: false,
  store: new TypeormStore({}),
  cookie: {
    maxAge: 1000 * 60 * 60 * 24 * 365,
    secure: process.env.NODE_ENV === 'production'
  },
  proxy: true
}))

and my routing-controllers one:

useExpressServer(app, {
  controllers: [join(__dirname, 'controller', '*.js')],
  middlewares: [join(__dirname, 'middleware', '*.js')],
  defaultErrorHandler: false
})

If I enable default error handler that route, which has a required parameter, fails:

@Post('/test')
test( @BodyParam('daw', { required: true }) daw: boolean) {
  return {
    ok: true
  }
}

because it sends an empty response, while setting content-length correctly, which is strange...

HTTP/1.1 500 Internal Server Error
Access-Control-Allow-Credentials: true
Content-Type: application/json; charset=utf-8
Content-Length: 65
Date: Sun, 05 Feb 2017 11:13:28 GMT
Connection: close

the logs are the following

  body-parser:json body already parsed +3ms
  express-session touching +1ms
  express-session split response +0ms
  express:router <anonymous>  : /api/v2/user/test +2ms
  finalhandler default 500 +1s
  finalhandler cannot 500 after headers sent +0ms
Parameter daw is required for request on POST /api/v2/user/test
{
  "name": "spaggiari-web-api",
  "hostname": "Danieles-MBP.station",
  "pid": 11779,
  "level": 50,
  "msg": "Parameter daw is required for request on POST /api/v2/user/test",
  "time": "2017-02-05T11:13:28.293Z",
  "v": 0
}
  express-session touched +18ms

[iH8c0ff33]

@19majkel94 have you been able to reproduce this issue, or is it related to something wrong with my code?

[pleerock]

@19majkel94 need your help because I never used sessions and have no idea how they work in express

[MichalLytek]

And I have no idea what is happening here and what this issue is about 😆

@iH8c0ff33
I would need a gist or a repo with working minimal codebase to reproduce the issue. Minimal, not copy-paste your project, just try to build it from scratch, maybe your other middleware conflict with express-session and the issue is not related with routing-controllers?
I would then only git clone, npm install, npm start and reproduce the issue without rewriting half of your app 😉

[iH8c0ff33]

@19majkel94 I'm trying to figure out which middleware causes this, but it's not that easy for me... I'll need some time

[iH8c0ff33]

@19majkel94

            // send error content
            if (action && action.isJsonTyped) {
                response.json(this.processJsonError(error));
            } else {
                response.send(this.processTextError(error)); // todo: no need to do it because express by default does it
            }
        }
        options.next(error);

could that be the problem? (options.next(error) is called even if response.send was already called)

[MichalLytek]

Yes and no. Sometimes you want default error handler to handle error response but you also want log some of the errors in *.log or in DB. So you create GlobalMiddlewareAfter and it's called after default error handler but you can't send anything to response, just use error and request objects. So the line must stay but it may conflict with other error handlers as you see.

[iH8c0ff33]

@19majkel94 Ok, but I see the response goes into finalhandler untouched after that and then it logs "can't {error code} after headers sent" and the request isn't actually sent, but only the headers.

[pleerock]

its normal (options.next(error) is called even if response.send was already called) because there are middlewares which can do the job after your controller actions. @iH8c0ff33 if you are still interested in this issue please create a minimal reproduction repo for @19majkel94 to debug, or close it if you aren't anymore.

[iH8c0ff33]

@19majkel94 can I send you my app as a reproduction? I really removed everything and don't know which is the problem since if I start a project with just a controller it just works, but my repo with everything but typeorm disabled doesn't work.

PS: If that's a problem I'll just close the issue since I don't think it's related to routing-controllers, or at least I'm not able to reproduce it

[pleerock]

ping @19majkel94

[MichalLytek]

pong 😆
@iH8c0ff33 you can send me your app, I will try to find some time to investigate this issue.