Relax constraint on SqlExpr equality operators to just Equiv#146
Merged
oyvindberg merged 2 commits intotypr-dev:mainfrom May 28, 2025
Merged
Relax constraint on SqlExpr equality operators to just Equiv#146oyvindberg merged 2 commits intotypr-dev:mainfrom
oyvindberg merged 2 commits intotypr-dev:mainfrom
Conversation
We don't need an Ordering for `===`. Many types have an Equiv instance but not an Ordering.
Collaborator
|
has that always been there?! never seen it before! but the change looks good. could you update the corresponding file for zio as well please? |
kolemannix
force-pushed
the
relax_eq_constraint
branch
from
57c670d to
00a464b
Compare
Collaborator
|
Nice, thanks! Ill get a release out in a few days. Ping me if i forget, these days are quite busy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need a full
Orderingfor===and!==Many types have an
Equivinstance but not anOrdering.This can save user code from needing to create a bogus ordering.