Fix TestInsert for Kotlin and Java#175
Merged
oyvindberg merged 2 commits intomainfrom Dec 27, 2025
Merged
Conversation
TestInsert now works properly for all three JVM languages:
- **Kotlin**: Fixed by adding default parameter values for Defaulted fields
- **Java**: Implemented fluent `Inserter<U,R>` pattern since Java lacks default parameters
## Java Usage
```java
// Simple insert
var row = testInsert.personBusinessentity().insert(c);
// With required parameters
var person = testInsert.personPerson(entityId, "EM", firstName).insert(c);
// Customize with .with() before inserting
var product = testInsert.productionProduct(...)
.with(row -> row.withName(new Name("Custom")))
.insert(c);
```
## Changes
- Add `Inserter<U,R>` interface in foundations-jdbc with `of()`, `with()`, `insert()`
- Generate Inserter-based methods for Java, default parameters for Kotlin/Scala
- Fix Java code generation in ComputedTestInserts:
- Use jvm.New() for proper constructor calls
- Fully qualify Defaulted.UseDefault
- Use string constructors for Int2Vector/Vector
- Language-native list access for enum selection
- Update Java tests to use new API
- Update documentation with Java examples
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestInsert now works properly for all three JVM languages:
Inserter<U,R>pattern since Java lacks default parametersJava Usage
Changes
Inserter<U,R>interface in foundations-jdbc withof(),with(),insert()Test plan
🤖 Generated with Claude Code