Improve connection API and test infrastructure#181
Merged
oyvindberg merged 6 commits intomainfrom Jan 4, 2026
Merged
Conversation
- Add ConnectionSource interface unifying pooled and non-pooled connection sources - Add SimpleDataSource for non-pooled connections (wraps DriverManager) - Add ConnectionSettings for connection behavior (isolation, autoCommit, readOnly, etc.) - Move connection settings from PoolConfig to ConnectionSettings - Add transactor() shortcuts to DatabaseConfig for common use cases - Update PooledDataSource to implement ConnectionSource - Remove config::connect from Transactor (use ConnectionSource instead) This provides a clean, unified API: - config.transactor() for quick non-pooled access - config.transactor(settings, strategy) for customized non-pooled - HikariDataSourceFactory.create(config, settings, pool).transactor() for pooled 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
When tests run in parallel across multiple JVMs, git operations can conflict. This adds proper file-based locking to ensure exclusive access to git add. - Add test-utils project with SnapshotTestUtils (Java) - withGitLock() uses FileChannel.lock() for cross-JVM file locking - Update all SnapshotTest files to use shared utility - Update WithConnection files to use new Transactor API - Add .snapshot-test.lock to .gitignore 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Migrate from `new Transactor(config, strategy)` to `config.transactor(strategy)` for all database testers. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Use parallel streams and unique table names per test case to enable concurrent execution across PgTypeTest, MariaTypeTest, DuckDbTypeTest, OracleTypeTest, SqlServerTypeTest, and Db2TypeTest. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Update DuckDB Kotlin to use DriverManager.getConnection - Update DB2 Java to use Transactor pattern - Update all Kotlin test helpers to use CONFIG.transactor() method 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code