reorganize main module to import from the utpm library#111
Merged
Thumuss merged 1 commit intotypst-community:mainfrom Mar 4, 2026
Merged
reorganize main module to import from the utpm library#111Thumuss merged 1 commit intotypst-community:mainfrom
Thumuss merged 1 commit intotypst-community:mainfrom
Conversation
…of declaring its own modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
main.rsandlib.rsdeclare the same modules (utils,commands,buildthrough shadow_rs). This is a bit of a footgun, because the library and binary are two separate crates. Worst case, something like this can happen:I thus removed all modules declared in
main.rsand replaced them with imports ofutpm::.... If my intuition is correct, this should also improve compile times, since the utpm could should previously have been compiled twice. (Edit: CI runs indicate there is a time difference, although not as significant as halving compilation time would be.)