Skip to content

Conversation

@tingerrr
Copy link
Member

It seems that James already set all values to 0.2.2 in advance.

Closes #52.

@tingerrr tingerrr force-pushed the tingerrr/kpmzlzuyvlus branch from 66ce1ce to de1090d Compare February 13, 2025 18:29
matrix:
# add any other Typst versions that your package should support
typst-version: ["0.11"]
typst-version: ["0.13.0-rc1"]
Copy link
Contributor

@eltos eltos Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to keep 0.12 in addition to 0.13 for a while, testing against both (since it's a matrix anyway). Not all templates and packages might make a release in time for 0.13, and by testing against both you could be sure not to break anything in the transition period.

Also, might be good to spell "0.13" and allow pre-releases, so you don't have to update the CI for every RC and stable release. Just as a suggestion, because I did exactly this in my template now too.

    strategy:
      matrix:
        typst-version: ["0.12", "0.13"]
      - name: Setup typst
        uses: typst-community/setup-typst@v3
        with:
          typst-version: ${{ matrix.typst-version }}
          allow-prereleases: true

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually just update to run CI because I can't set up the old version of typst-test. That being said, I'll add back 0.12 after I made CI pass.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, unfortunately that won't work for now because the output is actually different per version, even if I used compile-only tests where I can some of them actually depend on the output.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, didn't think of that. Never mind.

In the long term, it might be worth to rewrite the tests to use assertions rather than visual output compare, since I don't think that is necessary. Not a job for tonight, though. ;)

@tingerrr
Copy link
Member Author

I guess Tytanic failing locally was not just a fluke...

@eltos
Copy link
Contributor

eltos commented Feb 13, 2025

I think it's failing because #54 is not yet merged in your tingerrr/kpmzlzuyvlus

@tingerrr tingerrr force-pushed the tingerrr/kpmzlzuyvlus branch from de1090d to f663ac4 Compare February 13, 2025 18:52
@tingerrr
Copy link
Member Author

Yes but also because of the differences in output which prevents usage of matrix tests for now.

@tingerrr
Copy link
Member Author

Unfortuantely I'm only the bus factor +1 guy here, the test suite passes and that's more important than the doc working (that one runs fine on 0.12 it seems).

@tingerrr tingerrr merged commit 8b47671 into main Feb 13, 2025
1 check failed
@tingerrr tingerrr deleted the tingerrr/kpmzlzuyvlus branch February 13, 2025 18:58
@tingerrr
Copy link
Member Author

tingerrr commented Feb 13, 2025

cc: @jamesrswift

TLDR: I've updated the CI to 0.13.0-rc1 for now, the tests seem to pass, and I'll cut a release with this as 0.2.2. By the time you're back, you may want to update the manual and the tests to 0.13.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prepare 0.2.2 release

3 participants