-
Notifications
You must be signed in to change notification settings - Fork 6
release: 0.2.2 #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 0.2.2 #55
Conversation
66ce1ce to
de1090d
Compare
| matrix: | ||
| # add any other Typst versions that your package should support | ||
| typst-version: ["0.11"] | ||
| typst-version: ["0.13.0-rc1"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be good to keep 0.12 in addition to 0.13 for a while, testing against both (since it's a matrix anyway). Not all templates and packages might make a release in time for 0.13, and by testing against both you could be sure not to break anything in the transition period.
Also, might be good to spell "0.13" and allow pre-releases, so you don't have to update the CI for every RC and stable release. Just as a suggestion, because I did exactly this in my template now too.
strategy:
matrix:
typst-version: ["0.12", "0.13"] - name: Setup typst
uses: typst-community/setup-typst@v3
with:
typst-version: ${{ matrix.typst-version }}
allow-prereleases: trueThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually just update to run CI because I can't set up the old version of typst-test. That being said, I'll add back 0.12 after I made CI pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, unfortunately that won't work for now because the output is actually different per version, even if I used compile-only tests where I can some of them actually depend on the output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, didn't think of that. Never mind.
In the long term, it might be worth to rewrite the tests to use assertions rather than visual output compare, since I don't think that is necessary. Not a job for tonight, though. ;)
|
I guess Tytanic failing locally was not just a fluke... |
|
I think it's failing because #54 is not yet merged in your |
de1090d to
f663ac4
Compare
|
Yes but also because of the differences in output which prevents usage of matrix tests for now. |
|
Unfortuantely I'm only the bus factor +1 guy here, the test suite passes and that's more important than the doc working (that one runs fine on 0.12 it seems). |
|
cc: @jamesrswift TLDR: I've updated the CI to |
It seems that James already set all values to 0.2.2 in advance.
Closes #52.