-
Notifications
You must be signed in to change notification settings - Fork 13
feat: Hono JSXによるSSGのプロジェクトを追加 #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 51 out of 57 changed files in this pull request and generated 5 comments.
Files not reviewed (6)
- website/.editorconfig: Language not supported
- website/.gitignore: Language not supported
- website/package.json: Language not supported
- website/public/assets/index2ja.json: Language not supported
- website/public/assets/site.webmanifest: Language not supported
- website/public/styles/custom.css: Language not supported
| return ( | ||
| <> | ||
| {func.params.map((param, index) => ( | ||
| <div> |
Copilot
AI
Apr 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Iteration items rendered inside the map are missing a unique 'key' prop. Consider adding a key attribute (e.g. key={index} or a unique identifier) to the top-level element inside the map.
| <div> | |
| <div key={param.name}> |
| <span class="typ-func">{func.name}</span>( | ||
| <div class="arguments"> | ||
| {func.params.map((param, index) => ( | ||
| <span class="overview-param"> |
Copilot
AI
Apr 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mapped elements for function parameters should include a unique key attribute to ensure stable rendering. Please add a key prop to the root element returned by each iteration.
| <span class="overview-param"> | |
| <span class="overview-param" key={param.name || index}> |
| <h2 id="functions">Function</h2> | ||
|
|
||
| {content.functions.map((method, index) => ( | ||
| <div> |
Copilot
AI
Apr 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list items rendered inside the map lack a unique key prop. Adding a key attribute will help with element reconciliation during re-renders.
| <div> | |
| <div key={method.name || `function-${index}`}> |
| <h2 id="definitions">定義</h2> | ||
| <ul class="subgridded"> | ||
| {page.body.content.items.map((item) => ( | ||
| <li> |
Copilot
AI
Apr 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each item in the map should have a unique key prop to ensure proper rendering. Please add a key attribute to the
| <li> | |
| <li key={item.route}> |
| </h2> | ||
|
|
||
| {content.scope.map((method, index) => ( | ||
| <div> |
Copilot
AI
Apr 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The iteration over 'content.scope' items is missing a unique key prop. Adding a key attribute to the wrapper element in the map is recommended for stable list rendering.
| <div> | |
| <div key={method.name || `method-${index}`}> |
|
ご対応いただきありがとうございます。私が手が出せなかった部分なため大変助かります。 実行方法について、確認させてください。
原因と対策は思いつきますでしょうか? |
|
Trailing Slash Middlewareと |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ご対応いただきありがとうございました。無事動作確認ができました。
1687d72 to
0509a83
Compare
cf. https://github.com/typst-jp/typst-jp.github.io/issues/54
変更点
website/にHonoのプロジェクトを作成した確認事項
bun run devで開発サーバーを利用できるbun run buildでビルドができるbun run previewでビルド結果がプレビューできる備考