ci: textlintのエラーの抑制を無効化 #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR re-enables failing the CI on textlint errors by removing suppression flags, and updates a doc comment’s punctuation for consistency.
- Remove
continue-on-error: truefrom markdown and HTML lint steps to enforce textlint errors - Adjust a reference doc comment by removing the trailing period inside parentheses
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/typst-library/src/model/reference.rs | Removed trailing period in a doc comment example |
| .github/workflows/deploy.yml | Deleted continue-on-error: true lines from textlint lint jobs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
しばらくCIではtextlintのエラーを抑制して運用してきましたが、特に問題もなかったのでエラーの抑制を無効化しました。