-
Notifications
You must be signed in to change notification settings - Fork 13
feat: Webサイトに全文検索を実装 #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Webサイトに全文検索を実装 #157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a full-text search feature on the website through pagefind integration.
- Adds a new SearchWindow component and exports it through the common UI index.
- Integrates search functionality into both the Header and BaseTemplate for a consistent search modal.
- Updates build scripts and documentation to generate the search index using pagefind.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| website/src/components/ui/common/index.ts | Exports the new SearchWindow component. |
| website/src/components/ui/common/SearchWindow.tsx | Implements the search window with pagefind integration. |
| website/src/components/ui/common/Header.tsx | Adds search buttons with the new SearchIcon. |
| website/src/components/templates/BaseTemplate.tsx | Integrates searchOpen state and modal rendering for SearchWindow. |
| website/src/components/icons/index.ts | Exports the new SearchIcon component. |
| website/src/components/icons/SearchIcon.tsx | Implements the search icon component. |
| website/package.json | Updates build commands and adds the pagefind dependency. |
| website/README.md | Documents instructions for full-text search testing. |
c492153 to
6802317
Compare
kimushun1101
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SP、PCで検索機能を確認できました。
export VITE_LISTEN_ALL_ADDRESSES=true
mise run generate
# mise run dev # READMEにあるようにこれでは検索機能は使えない
mise run preview
確認ですが、ひとまずこのPRでは以下の状態でよろしいでしょうか?
私としては困っていないため大丈夫です。
bun run devで動かせない。bun run buildで以下のメッセージがでています。Note: Pagefind doesn't support stemming for the language ja. Search will still work, but will not match across root words.
gomazarashi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
検索機能が問題なく利用できることを確認しました。
こちらの詳細はドキュメントのMultilingual searchに書かれています。 |
close https://github.com/typst-jp/typst-jp.github.io/issues/142
確認事項