Optimize From<Vec<T>> for EcoVec<T>#50
Merged
laurmaedje merged 5 commits intotypst:mainfrom Aug 4, 2025
Merged
Conversation
laurmaedje
reviewed
Jul 21, 2025
…copy_nonoverlapping
From<Vec<T>> for EcoVec<T>
Member
|
Thanks! |
Member
|
Published ecow 0.2.6 with this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by the implementation of
From<Vec<T>>forArc<[T]>:https://github.com/rust-lang/rust/blob/175e04331be56c5b4bdf77478434b1a5e0556770/library/alloc/src/sync.rs#L3823-L3851
Vec::into_raw_parts(self)APIs are experimental, so we can't use them, even though the stdlib Arc implementation uses it internally.When we copy/move the elements from the Vec into the EcoVec, we need to ensure that the items don't get dropped twice.
Vec::set_len(&mut self, len: usize)to set the length to 0, which ensures that when the Vec is dropped later, and its buffer is freed - it doesn't run drop on the individual items that were moved into the EcoVec.