Add a few AsRef impls to EcoString#55
Merged
laurmaedje merged 1 commit intotypst:mainfrom Sep 19, 2025
Merged
Conversation
Member
|
I find the coupling to random other types a bit unfortunate, but oh well. In std, the Path/OsStr impls actually live in the path and ffi modules, since the string type is the more general one, but we don't have that luxury here. |
laurmaedje
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly for convenience, I kept running into
Path::join(&EcoString)requiring an extraEcoString::as_str().I left out
Borrowbecause forPathstheEqrequirements dont't hold and&[u8]/OsStrjust seems odd.