Refactor Nix flake: extract package, apply best practices#79
Merged
Conversation
ck3d
commented
Jun 28, 2026
ck3d
commented
Contributor
- Fix outdated cargoHash and modernize buildInputs
- Extract package definition from flake.nix into standalone package.nix to allow non-flake usage
- Add nixfmt-tree as the default formatter and apply formatting to all Nix files
- Remove flake-utils input; inline system iteration via lib.genAttrs with an explicit supportedSystems list
- Eliminate 'with pkgs.dockerTools;' in docker-image copyToRoot for clarity
- Fix outdated cargoHash and modernize buildInputs (drop openssl.dev in favor of openssl, which propagates openssl.dev automatically) - Extract package definition from flake.nix into standalone package.nix to allow non-flake usage (nix-build -f package.nix, callPackage, etc.) - Add nixfmt-tree as the default formatter and apply formatting to all Nix files - Remove flake-utils input; inline system iteration via lib.genAttrs with an explicit supportedSystems list (standard Nixpkgs pattern) - Eliminate 'with pkgs.dockerTools;' in docker-image copyToRoot for clarity and to follow current Nixpkgs conventions
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.