Properly terminate in subroutines with an endchar operator#22
Merged
laurmaedje merged 3 commits intomainfrom May 4, 2026
Merged
Properly terminate in subroutines with an endchar operator#22laurmaedje merged 3 commits intomainfrom
endchar operator#22laurmaedje merged 3 commits intomainfrom
Conversation
Member
|
Let me know if I should cut a release. |
Collaborator
Author
|
Not urgent I think. I let codex do an “audit” and it found a few more things (some of which related to variable fonts handling), so might be worth fixing those first as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the Type2 specification, subroutines can have the
endcharoperator:When desubroutinizing a glyph, we should therefore abort in case we encounter such an instruction, instead of keeping decompiling new instructions. See also the diff of the test in the second commit, which now matches what fonttools emits when desubroutinizing this font.