Fix panic when division overflows in calc
#7419
Merged
+42
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PgBiel
reviewed
Nov 20, 2025
Contributor
PgBiel
left a comment
PgBiel
left a comment
There was a problem hiding this comment.
Looks good, thank you! My review will focus mostly on docs. I'll note that a few suggestions are only to reflow comments so they adhere to our limit of up to 80 columns on each comment line.
Co-Authored-By: PgBiel <9021226+PgBiel@users.noreply.github.com>
laurmaedje
added
scripting
laurmaedje
added
waiting-on-review
Member
|
Thanks! |
laurmaedje
added a commit
that referenced
this pull request
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #7392 (comment). There is only one case where overflow happens:
i64::MIN.checked_div(-1)1Footnotes
https://doc.rust-lang.org/nightly/std/primitive.i64.html#method.checked_div ↩