feat: #34 add repo URL to version output#35
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the version output to include the correct repository URL and a link to the repository. The change is correct, but I've suggested a small improvement to define the URL as a constant to avoid repetition and improve maintainability.
| s += fmt.Sprintf("\nhttps://github.com/tyrantkhan/bitbucket-cli/releases/tag/v%s", Version) | ||
| s += "\nhttps://github.com/tyrantkhan/bitbucket-cli" |
There was a problem hiding this comment.
For better maintainability and to avoid repetition, you could define the repository URL as a constant and combine the string concatenations into a single fmt.Sprintf call. This makes it easier to update in the future if it ever changes.
| s += fmt.Sprintf("\nhttps://github.com/tyrantkhan/bitbucket-cli/releases/tag/v%s", Version) | |
| s += "\nhttps://github.com/tyrantkhan/bitbucket-cli" | |
| const repoURL = "https://github.com/tyrantkhan/bitbucket-cli" | |
| s += fmt.Sprintf("\n%s/releases/tag/v%s\n%s", repoURL, Version, repoURL) |
Summary
bitbucket-clirepo nameTest PR to verify release-please picks up both
featandfixcommits from squash merge body.Closes #34