Skip to content

fix(turn): handle interruption and suppress notifications#35

Merged
tyulyukov merged 2 commits intomainfrom
marcode/fix/stop-turn-and-worktree
Apr 9, 2026
Merged

fix(turn): handle interruption and suppress notifications#35
tyulyukov merged 2 commits intomainfrom
marcode/fix/stop-turn-and-worktree

Conversation

@tyulyukov
Copy link
Copy Markdown
Owner

Summary

This PR addresses three related issues with turn interruption and notification handling:

  • Suppressed error messages for interrupted turns: When a turn is interrupted, the error message is now treated like a successful result (cleared), preventing spurious error states in the UI
  • Cleared branch context on worktree mode switch: Switching to worktree environment mode now properly resets the branch field in draft context, avoiding state inconsistency
  • Silent notifications for turn lifecycle events: Added silent suppression for "turn-stopped" and "turn-interrupted" notification reasons, preventing duplicate sound feedback during turn cancellation

Testing

  • Verify interrupting an active turn no longer shows error messages in the UI
  • Confirm switching environment mode from standard to worktree clears the branch field
  • Check that stopping/interrupting turns doesn't trigger notification sounds (visual indicators still show)
  • Run bun fmt, bun lint, and bun typecheck to validate code quality

Checkpoint revert to turn 0 now succeeds without an active provider
session when workspace is a git repo. Updated assertions to check for
thread.reverted domain event instead of checkpoint.revert.failed activity.
- Treat interrupted results as success (no error message) in Claude adapter
- Clear branch selection when switching to worktree environment mode
- Suppress sound notifications for turn-stopped and turn-interrupted events
@github-actions github-actions Bot added the size:S label Apr 9, 2026
@tyulyukov tyulyukov merged commit 508be39 into main Apr 9, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant