chore: self-host model downloads from GitHub assets release#15
Conversation
Point all 4 ONNX model download URLs at the new 'assets' release on this repo instead of third-party locations (visomaster GitHub release and HuggingFace). SHA256 checksums are unchanged.
There was a problem hiding this comment.
Pull request overview
This PR updates Facelock’s ONNX model manifest to self-host model downloads from this repository’s GitHub Releases (tag assets), removing reliance on third-party hosting.
Changes:
- Updated all model
urlentries inmodels/manifest.tomltohttps://github.com/tyvsmith/facelock/releases/download/assets/<filename>. - Updated the manifest header comments to reflect the new hosting location and checksum verification behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Models are hosted in the GitHub "assets" release: | ||
| # https://github.com/tyvsmith/facelock/releases/tag/assets |
There was a problem hiding this comment.
Using a non-versioned GitHub release tag (assets) makes these model URLs effectively mutable (tags/assets can be replaced). If the release assets ever change, older binaries will download the new file and then fail SHA256 verification, breaking facelock setup for existing versions. Consider switching to a versioned/immutable tag (e.g. vX.Y.Z-models) or otherwise guaranteeing assets is append-only and never rewritten.
| # Models are hosted in the GitHub "assets" release: | ||
| # https://github.com/tyvsmith/facelock/releases/tag/assets | ||
| # | ||
| # The sha256 checksums remain the same regardless of hosting source. | ||
| # The sha256 checksums are verified at download time and at daemon startup. |
There was a problem hiding this comment.
After changing the canonical model hosting location to the assets release, some docs still reference the old hosting/tag (v0.1.0-models) and visomaster URLs (e.g. docs/testing-roadmap.md, docs/troubleshooting.md, book/src/troubleshooting.md). Updating those references in the same PR would avoid confusing users troubleshooting download failures.
Summary
assets) containing all 4 ONNX model filesmodels/manifest.tomlto download models from our own repo instead of third-party sourcesWhat changed
All model download URLs in
models/manifest.tomlnow point to:Previously they pointed to
visomaster/visomaster-assets(3 models) and HuggingFace (1 model).SHA256 checksums are unchanged — same files, just self-hosted.
Models in the assets release
scrfd_2.5g_bnkps.onnxw600k_r50.onnxdet_10g.onnxglintr100.onnxWhy
Eliminates dependency on third-party hosting for model downloads. Users no longer need to rely on visomaster's GitHub releases or HuggingFace being available.