style: run cargo fmt to fix CI formatting check#2
Closed
Copilot wants to merge 2 commits into
Closed
Conversation
Co-authored-by: tyvsmith <309657+tyvsmith@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CI failures due to rustfmt formatting issues
style: run cargo fmt to fix CI formatting check
Mar 18, 2026
7 tasks
tyvsmith
added a commit
that referenced
this pull request
May 24, 2026
…rvice opt-in Replaces the hardcoded [sudo, polkit-1, hyprlock] list with a PAM_CANDIDATES table that is filtered at runtime by /etc/pam.d/<service> existence, then presented to the user one service at a time via dialoguer::Confirm. New services covered: - swaylock (Sway/wlroots screen lock) — default YES - kscreenlocker_greet (KDE Plasma screen lock) — default YES - gdm-password (GNOME display manager login screen) — default NO - sddm (KDE display manager login screen) — default NO - lightdm (Ubuntu/Xfce/Mint display manager login screen) — default NO Default-YES rationale: screen lockers have safe password fallback; worst case is an extra Enter keypress. Default-NO rationale: display manager login screens lock users out of the system if face auth fails and they have no other recovery path; opt-in should be explicit. Explicit non-targets (never offered, even if /etc/pam.d/<name> exists): - system-auth / common-auth: shared stacks that would spread face auth to passwd, su, chsh, chfn, etc. - login: TTY login; camera may not be initialized at boot. - su, passwd, chsh, chfn: credential/privilege-change tools that must require a real password. Wizard flow change: replaces MultiSelect-all-at-once with individual Confirm prompts so the user sees the default recommendation per service. Non-interactive mode uses each candidate's default_enabled value. Adds two unit tests: - detect_candidates_filters_by_presence: verifies candidates_in() against a TempDir; only services with a matching file are returned. - no_excluded_services_in_candidates: asserts the excluded service list never appears in PAM_CANDIDATES. Adds tempfile as a dev-dependency of facelock-cli. Note: PR #1 (uninstall cleanup) and PR #2 (PAM confirmation prompt) are racing. This PR may have minor conflicts with #2 if both touch the per-service iteration; resolve at merge time. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo fmt --all -- --checkhas been failing on every push tomainsince the initial commit — source files were committed without runningrustfmt.facelock-camera,facelock-cli,facelock-daemon,facelock-store,facelock-tpm, andfacelock-polkitTPM Tests (swtpm)andContainer PAM Smoke Testjobs, both gated onbuild-and-testOriginal prompt
This pull request was created from Copilot chat.
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.