Added the ability to change the text shown on the wifisaved screen#474
Closed
JacobBriggsAckama wants to merge 4 commits intotzapu:masterfrom
Closed
Added the ability to change the text shown on the wifisaved screen#474JacobBriggsAckama wants to merge 4 commits intotzapu:masterfrom
JacobBriggsAckama wants to merge 4 commits intotzapu:masterfrom
Conversation
JacobBriggsAckama
pushed a commit
to WhareHauora/wharehauora-wifi-gateway
that referenced
this pull request
Dec 20, 2017
Added a custom text call for a version of WiFiManager that is pending in a PR here: tzapu/WiFiManager#474 there is already another PR that accomplishes a similar thing though, so I'll wait till the maintainer notices it and we can talk later aboput how to proceed
Author
|
I do like your solution better @dronov - but neither of them are merged.... |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to be able to change the text shown on the wifisaved screen, here is my attempt -is this a good approach?