make WIFI_MANAGER_MAX_PARAMS customizable#487
Merged
tablatronix merged 1 commit intotzapu:masterfrom Feb 1, 2018
mtiutiu:master
Merged
make WIFI_MANAGER_MAX_PARAMS customizable#487tablatronix merged 1 commit intotzapu:masterfrom mtiutiu:master
tablatronix merged 1 commit intotzapu:masterfrom
mtiutiu:master
Conversation
Collaborator
|
Note that setting this is no longer needed, as memory is autoallocated for params now |
Contributor
Author
|
I noticed that. So yeah it kinda makes no sense now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it's pretty useful to have this parameter customizable so that users can change it from outside if required (e.g platformio, make, etc).
For example when using platformio I can set this in platformio.ini:
build_flags = -DWIFI_MANAGER_MAX_PARAMS=20
This allows me to change the value at compile time without modifying the library source code. I also provided the default value for it when not defined outside or somewhere else - you can see that in the code changes that I want to propose.
This approach can be used for other defines in this library source code if desired/required.
Very nice work btw regarding this library - very useful. Thanks.