Skip to content

Added custom static DNS#562

Closed
debsahu wants to merge 1 commit intotzapu:developmentfrom
debsahu:development
Closed

Added custom static DNS#562
debsahu wants to merge 1 commit intotzapu:developmentfrom
debsahu:development

Conversation

@debsahu
Copy link
Copy Markdown
Contributor

@debsahu debsahu commented Mar 15, 2018

Used vim in linux to edit the files. Hopefully didnt create a mess.

@tablatronix
Copy link
Copy Markdown
Collaborator

I had free time so i fixed it, already merged, thanks

@debsahu
Copy link
Copy Markdown
Contributor Author

debsahu commented Mar 15, 2018

lol, thanks :}

@tablatronix
Copy link
Copy Markdown
Collaborator

I did change it to always show on webpage though, if showstaticfields is on

@debsahu
Copy link
Copy Markdown
Contributor Author

debsahu commented Mar 15, 2018

learning to use github effectively, still a learning from googling.

@tablatronix
Copy link
Copy Markdown
Collaborator

tablatronix commented Mar 15, 2018

check out core.autocrlf = auto, it keeps whitespaces same as repo
Also checkout github desktop, I use it alot when I am remote or do not feel like installing git, if you are not already using it

@debsahu debsahu deleted the development branch March 15, 2018 21:14
@debsahu
Copy link
Copy Markdown
Contributor Author

debsahu commented Mar 15, 2018

So if the user only specifies ip, gw and sn, then the DNS will still pop up in the web interface. That's why I set it as optional, else we got to edit the readme that DNS is mandatory.

@tablatronix
Copy link
Copy Markdown
Collaborator

tablatronix commented Mar 16, 2018

Why would it be mandatory, it can be blank, the problem is showstaticfields and if staticip tied togsther, i might add a more detailed customization option to flag each one regardless of custom or not

@tablatronix
Copy link
Copy Markdown
Collaborator

Showstaticfields ip,gw,sn,dns bool, or maybe three state int 0,1,2 show always, show if set, show never

@tablatronix
Copy link
Copy Markdown
Collaborator

Maybe just 2 toggles, ip and dns, if you enable staticip you probsbly always want gw and sn also always

@debsahu
Copy link
Copy Markdown
Contributor Author

debsahu commented Mar 16, 2018

Exactly, static IP with and without dns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants