Change the web server and tcp to be async#794
Change the web server and tcp to be async#794bwssytems wants to merge 538 commits intotzapu:masterfrom
Conversation
…to development
Added Custom DNS, fix newlines
Prboably going to add a vector for this, I do not want to add the overhead of std::array for something optional
This kind of makes it a pain in the ass for users, not sure how to make this easier, I can take in an array of string ids, with a count arg, makes it easier, but then users can pass nonsense in, this way its enum ids, but damn it sure is convoluted. Welcome to ideas here...
```c++
std::vector<WiFiManager::menu_page_t> menu = {wm.MENU_WIFI,wm.MENU_INFO,wm.MENU_PARAM,wm.MENU_CLOSE,wm.MENU_SEP,wm.MENU_ERASE,wm.MENU_EXIT};
wm.setMenu(menu);
```
…to development
|
any progress here - is it the goal to move to async or maybe support both (by define switch)? |
|
@Jorgen-VikingGod You can just replace the WiFiManager library with the one from my branch "https://github.com/bwssytems/WiFiManager/tree/ConvertToAsync" and you will be good to go |
|
@bwssytems Can you go over the changes you made to implement, this PR diff is illegible. Or create a new PR without the messy history? |
|
@tablatronix The best thing is to go to my branch and do the diff as that will look much cleaner. The changes were changing to the async items instead of the ESP32/8266 versions and then updating the logging. |
|
ohh your PR target is master not development branch, lol I was like wtf is going on, could not diff it. |
|
I guess I can change it but here we go |
|
These changes are minor enough to simply swap them in using a processor directive. |
|
That would work, Shall we close this pull request? |
|
Sure we can reference the issue and I will work on getting this implemented soon |
15 participants
Changed the sub system to use the ESPAsyncWebServer and AsyncTCP. Allows for better TCP handling.