Skip to content

Conversation

@yyewolf
Copy link
Collaborator

@yyewolf yyewolf commented Nov 18, 2025

This pull request enhances the handling of resource pausing during reconciliation and adds comprehensive end-to-end tests to ensure correct behavior when resources are paused and unpaused. The main changes focus on improving how the pause label prevents resource mutations, and verifying this functionality through new tests.

Pause logic improvements:

  • Refactored the pause label check so that resource mutation is skipped within the mutator function passed to CreateOrPatch, rather than skipping the entire reconciliation step. This allows for more granular control and ensures that only the mutation is bypassed when the pause label is present. [1] [2]

Testing enhancements:

  • Added a new end-to-end test to pause_tests.go that verifies a ConfigMap is not updated when it has the pause label, and resumes updating once the label is removed. The test checks initial creation, ensures data remains unchanged while paused, and validates correct updates after unpausing.

@yyewolf yyewolf self-assigned this Nov 18, 2025
@yyewolf yyewolf added the enhancement New feature or request label Nov 18, 2025
@yyewolf yyewolf added this to the v1.2.0 milestone Nov 18, 2025
@yyewolf yyewolf added bug Something isn't working and removed enhancement New feature or request labels Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants