Reset Password

[fawaf]

No description provided.

[goto-bus-stop]

Looking good :D

The config files in tasks/ were intentional, so people don't have to get their own API keys or set anything else up manually before running the dev server.

A lot has happened on master since march so there are a few things out of date here. Not as much as I expected though, so 😄

[goto-bus-stop]

This import was renamed to material-ui/svg-icons/communication/email in material-ui 0.15

[fawaf]

The config files in tasks/ were intentional, so people don't have to get their own API keys or set anything else up manually before running the dev server.

sure, but they could just copy the .example file to the real file (and make changes if needed).

[goto-bus-stop]

sure, but they could just copy the .example file to the real file (and make changes if needed).

Yeah, but that is an extra step that we'd need to document, and warn for when someone runs gulp serve if they haven't copied the files 😄 I don't think changes to these files will be common at all. Especially dev-test-secret.txt will never need to be changed for a dev server. The one thing that might change about the dev-server-config.json file is the port, but that can be overridden using the --port parameter to the serve task: gulp serve --port 80

For the cases where you would want to change the dev server configuration, like when testing a new media source, I think it'd be better to have an optional config file in the repo root and keep the current as defaults. But that's a separate issue and would warrant a separate PR 😃

[fawaf]

ah, interesting point. i'll revert that commit. i'll submit another pr later to allow usage of a separate config file.

[fawaf]

also,

For the cases where you would want to change the dev server configuration, like when testing a new media source, I think it'd be better to have an optional config file in the repo root and keep the current as defaults. But that's a separate issue and would warrant a separate PR 😃

i think you mean prod server? if one was to change the dev server config, he/she would just update the dev-server-config and commit it, right?

[goto-bus-stop]

I think we decided on adding a separate page for the "new password" inputs. After a rebase, the build system will be using webpack so that should be doable. I'm not 100% on how these things go since I haven't done a "single-page" app with multiple pages (lol) before but I have some thoughts/guesses/things:

The new page would need its own javascript entry point and PasswordReset form. the main app has app.js, but the forgot password page could be simpler. Like the App.js shown here: http://www.material-ui.com/#/get-started/usage but rendering a form instead of MyAwesomeReactComponent. The form can use the stuff from src/components/Form/* like the dialogs do and that SHOULD be fine.

The new passwordReset.js (or something) entry point should be configured in webpack.config.js:

https://webpack.github.io/docs/multiple-entry-points.html

And that entry point I THINK can then be built to a separate html file by duplicating this HtmlPlugin instance in the plugins array: https://github.com/u-wave/web/blob/master/webpack.config.js#L33
but replacing the app chunk with the passwordReset chunk, and setting the filename to reset.html or whatever. (Se https://github.com/ampedandwired/html-webpack-plugin for HtmlPlugin options)
I THINK the index.html template can just be reused.

Hope that makes sense :'D