Chat performance fixes #543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goto-bus-stop
force-pushed
the
bugfix/chat-performance
branch
from
af19dcc to
6dbf342
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches change two things that could cause the entire chat message list to rerender every time a new message was received.
The chat delete button handlers for moderators are now not recreated each time the list rerenders, so no longer cause all chat messages to rerender too.
I removed the striped chat message display (maybe will add it back with a CSS-only solution later) because it caused all chat messages to switch their
alternateclassname when 1) a message is deleted or 2) a new message comes in whilst there are already 512 messages in scrollback. Now it looks like:Which honestly is not that bad 🤔 but I'll see if the stripes can work well using just CSS.