build: Enable lodash paths. #549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use the lodash dotted path `a.b.c` functionality in `mergeIncludedModels`, so enable it again. Also changes one use of `find` with a matcher object to a function. Also uses the Lodash Webpack plugin everywhere, instead of just in the production build, so it becomes easier to catch these problems in development.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit of a follow-up to #512.
We used the lodash dotted path
a.b.cfunctionality inmergeIncludedModels, so enable it again in the lodashwebpack plugin.
Also changes one use of
findwith a matcher object to a function.Also uses the Lodash Webpack plugin everywhere, instead of just in
the production build, so it becomes easier to catch these problems
in development.