fix(lint): remove useless null initializer in buildBwipOptions#79
Merged
Conversation
ESLint 10's no-useless-assignment rule, enabled via @eslint/js 10's recommended config (dependabot PR #77), flags the `let opts = null` in buildBwipOptions as dead. Every reachable case in the switch assigns opts before `break` and the `default` arm returns early, so the initial null is never read. Drops the initializer and the redundant truthiness guard before the rotation branch (opts is unconditionally assigned by the time we reach it). Behaviour is unchanged.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes a redundant null initializer for the 'opts' variable in 'buildBwipOptions' to comply with ESLint 10's 'no-useless-assignment' rule. The 'opts' type was updated, and a subsequent null check was removed since the variable is now guaranteed to be assigned before use. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.