"trusted-click-element" seems broken in 1.71.1b1

[Procyon-b]

Tested on:

• FF 115esr + uBO 1.71.1b1
• chrome + uBO 1.71.1b1
• chrome + uBO 1.71.0
• chrome + uBO 1.54.0

The filter is:
wcostream.com##+js(trusted-click-element, button.btn-close#close-btn:not([disabled]))

The test page is:
https://www.wcoflix.tv/rent-a-girlfriend-season-5-episode-7-english-dubbed

The page has a countdown before the button becomes available (disabled attribute removed). Prior to today, removing the attribute and clicking the button immediately worked. But now, you have to wait the full countdown to navigate to the end-page without the site blocking the visitor.

This is where trusted-click seems broken. In non-beta versions of uBO, the click occurs at the moment the site enables the button.
In uBO beta, nothing happens, even if I add a parameter (like ,, 15000) . If I use the time attribute in older uBO, the click waits the correct time.

[gorhill]

I guess you mean 1.71.1b2?

There is a built-in timeout of 10s for the scriptlet, after which the scriptlet aborts. The fact that the site's timer is 10s means that whether the click occurs is extremely dependent on a given implementation of the scriptlet, and since I changed the implementation of the scriptlet, this edge case surfaced.

Is this a filter from a supported filter list? Given that the scriptlet's timeout is exactly the site's timer, the filter can be make more resilient with:

wcostream.com##+js(trusted-click-element, 'button.btn-close#close-btn:not([disabled]), 15000')

This will set the timeout at 15s.

To try to keep such edge cases from surfacing, I will extend the built-in timeout to 11s, this will be in next dev build.

[Procyon-b]

And FYI, FF updated uBO to 1.71.1b2 just know.

[Procyon-b]

Can you tell me if the click can be postponed to only activate after a few seconds ?
There is still this in the wiki:

optional, delay in ms how long the scriptlet will postphone the execution

I want to try firing the click a little bit earlier than 10s, but the use of :remove-attr(disabled) makes the click activate immediately.

[gorhill]

UBO's version is diverging from AdGuard's version, and that delay parameter I consider it obsolete, it's there for AdGuard's compatibility. You can add delays wherever you want in the list of comma-separated directive, for example:

wcostream.com##+js(trusted-click-element, '8000, button.btn-close#close-btn:not([disabled]), 15000')

This will add a delay of 8s before the element matching button.btn-close#close-btn:not([disabled]) is clicked, and the whole execution will timeout after 15s in case the element is never found.

[Procyon-b]

Thanks. Will try

[gorhill]

This works?

||embed.wcostream.com^$frame,uritransform=/inc\/embed\/index\.php/inc\/embed\/video-js-new.php/

From there: https://old.reddit.com/r/uBlockOrigin/comments/1twpk5k/watch_cartoons_is_detecting_ubo_again/. Problem is the poster is trying to use replace=, just need uritransform=.

---

This one works for both uBO and uBOL:

/\/inc\/embed\/index\.php/$frame,uritransform=//\/inc\/embed\/video-js-new.php/,from=wcoflix.tv,to=embed.wcostream.com

[krystian3w]

On my end works perfectly, even there are delays of up to 15 minutes with the new syntax.

I see the point of sticking to the old syntax only if you want it to work with uBo legacy by the Slovenian programmer:

https://github.com/UCyborg/uBlock-for-firefox-legacy/releases

(I don't follow the Germanic version of the forum https://msfn.org/board/topic/183923-extensions-ucjsucxul-scripts-css-stylesheets-and-custom-buttons-for-uxp-browsers-corrections-modifications-adjustments-and-recommendations/ - since the development of the Slovenian fork has also stopped, maybe work on the German one has been resumed).

And possibly in AdGuard as their on-the-fly parser doesn't support the new uBo logic.