Cache Prevalues for the Picker obj

[Hendy]

https://our.umbraco.org/projects/backoffice-extensions/nupickers/questionssuggestions/78916-db-calls-during-render#comment-252197

[drpeck]

Caching on application start is certainly a sensible approach, but could you not just look at the property value and determine the type based on the content (i.e. 1024,1099 is pretty likely to be CSV and 1024 is going to be XML). It would also mean that if the format was changed in the datatype then old values wouldn't break. The big BUT is what about 'relations only', but could you store 'relationsOnly' as the value then? Breaking change I guess...

[Hendy]

All prevalues are now cached as a var in the Picker obj after the first query - but we could use memory cache instead ? (and invalidate on save of data-type)

[drpeck]

Will that var persist across requests? If so then that sounds like it would resolve things. If not then I can create a PR using memory cache (once you've committed this change) if it would be of interest.

[Hendy]

Hi @drpeck, this var caching is already in the wild, but would be good to swap to using a memory cache (so, as you've highlighted, it's not inflated on first hit in each Picker obj), would be great to have a PR for that if you're willing :)

Perhaps the cache invalidation event would be in a class in the root called PickerCacheInvalidationEvents.cs ?

(have also been thinking of using memory cache for Picked items (key + label), so that the CSV & Relations only save formats, don't have to make another query to re-inflate)

[drpeck]

@Hendy It's on my TODO list. If by any chance I've not sorted in a timely manner than prompt me.

[Hendy]

sorry @drpeck, I couldn't help myself :) (should be fixed now tho, and the cache can be put to use on relations & CSV labels - via a config option maybe ?)