Update jQuery / Bootstrap, remove Fluid Infusion#252
Merged
bjagg merged 6 commits intouPortal-Project:masterfrom Apr 23, 2026
Merged
Update jQuery / Bootstrap, remove Fluid Infusion#252bjagg merged 6 commits intouPortal-Project:masterfrom
bjagg merged 6 commits intouPortal-Project:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the gateway UI to work with newer front-end dependencies (jQuery/Bootstrap) and removes reliance on older bundled scripts.
Changes:
- Replaced deprecated jQuery event shorthands with
.on(...)bindings. - Updated gateway “open in new page” URL construction to safely append query params and encode values.
- Removed the bundled jQuery 1.12.4 file and switched script sourcing/usage to portal-provided jQuery (
up.jQuery) and a Bootstrap modal.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/webapp/scripts/webproxy.js | Updates iframe load handler wiring to jQuery .on("load"). |
| src/main/webapp/scripts/jquery-1.12.4.min.js | Removes the old bundled jQuery library file. |
| src/main/webapp/WEB-INF/jsp/mobileGateway.jsp | Fixes window.open URL param concatenation and encoding. |
| src/main/webapp/WEB-INF/jsp/gatewayNewPage.jsp | Switches jQuery loading to a WebJars/resource-server path; updates ajax error binding. |
| src/main/webapp/WEB-INF/jsp/gateway.jsp | Replaces jQuery UI dialog usage with a Bootstrap modal; switches to up.jQuery; updates window.open URL building. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bjagg
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.