fix(nearest-derive): add Flat bounds to unbounded type params in emit impl#32
Merged
fix(nearest-derive): add Flat bounds to unbounded type params in emit impl#32
Conversation
… impl The generated `make()` methods were using `split_for_impl()` which only includes bounds explicitly written by the user. Type parameters without an explicit `Flat` bound (e.g. from a where clause) were missing the required `Flat` constraint on the impl block, causing compilation errors in downstream usage. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make()methods usedsplit_for_impl()which only includes bounds explicitly written by the userFlatbound were missing the required constraint on the impl blockouter_where_clause()that usesflat_bounded_param_namesandcombine_whereto infer and add missingFlatboundsTest plan
cargo test— all 183 tests passcargo xtask lint— clean🤖 Generated with Claude Code