Abort on packaging errors #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eraction to bypass other errors, add pip --quiet
ubaniabalogun
requested changes
Feb 5, 2020
index.js
Outdated
| setupContainer(){ | ||
| let out = this.runProcess('docker',['ps', '-a', '--filter',`name=${this.containerName}`,'--format','{{.Names}}']) | ||
| out = out.replace(/^\s+|\s+$/g, '') | ||
| console.log('SDLFKJSDL:KFJSDL:KFJ ', this.containerName) |
Owner
There was a problem hiding this comment.
I believe this is no longer needed
ubaniabalogun
requested changes
Feb 5, 2020
README.md
Outdated
| | useDocker | Boolean indicating whether to package pip dependencies using Docker. Set this to true if your project uses platform-specific compiled libraries like numpy. Requires a [Docker installation](https://www.docker.com/get-docker). | Yes. Defaults to `false` | | ||
| | dockerImage | The Docker image to use to compile functions if `useDocker` is set to `true`. Must be specified as `repository:tag`. If the image doesn't exist on the system, it will be downloaded. The initial download may take some time. | Yes. Defaults to `lambci/lambda:build-${provider.runtime}` | | ||
| | containerName | The desired name for the Docker container. | Yes. Defaults to `serverless-package-python-functions` | | ||
| | usePackagingErrorAlerts | Boolean indicating whether you want to stop deployment when packaging errors are detected. Example errors include: `useDocker` is enabled but the Docker service is not running, pip finds dependency mismatches, virtual environment errrors, etc.. When an error is detected, this will prompt via commandline to continue or abort deploy. | Yes. Defaults to `false` | |
Owner
There was a problem hiding this comment.
Let's go with a more descriptive/intuitive name, Like abortOnPackagingErrors
README.md
Outdated
| | useDocker | Boolean indicating whether to package pip dependencies using Docker. Set this to true if your project uses platform-specific compiled libraries like numpy. Requires a [Docker installation](https://www.docker.com/get-docker). | Yes. Defaults to `false` | | ||
| | dockerImage | The Docker image to use to compile functions if `useDocker` is set to `true`. Must be specified as `repository:tag`. If the image doesn't exist on the system, it will be downloaded. The initial download may take some time. | Yes. Defaults to `lambci/lambda:build-${provider.runtime}` | | ||
| | containerName | The desired name for the Docker container. | Yes. Defaults to `serverless-package-python-functions` | | ||
| | abortOnPackagingErrors | Boolean indicating whether you want to stop deployment when packaging errors are detected. Example errors include: `useDocker` is enabled but the Docker service is not running, pip finds dependency mismatches, virtual environment errrors, etc.. When an error is detected, this will prompt via commandline to continue or abort deploy. | Yes. Defaults to `false` | |
Owner
There was a problem hiding this comment.
Instead of Example errors include: let's go with: Examples of scenarios that will cause packaging errors include:
ubaniabalogun
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abort serverless deploy when plugin fails to package a lambda function properly.
if abortOnPackagingErrors: true -