FIX database connection exhaustion in worker and API endpoint#1067
Merged
ionparticle merged 1 commit intomasterfrom Mar 13, 2026
Merged
FIX database connection exhaustion in worker and API endpoint#1067ionparticle merged 1 commit intomasterfrom
ionparticle merged 1 commit intomasterfrom
Conversation
Member
xcompass
commented
Mar 13, 2026
xcompass
commented
- celery_worker.py: call db.session.remove() in ContextTask finally block so connections are returned to the pool after every task regardless of outcome; previously connections leaked until CELERY_WORKER_MAX_TASKS_PER_CHILD recycled the process
- assignment_search_enddate.py: replace per-request create_engine() (which spawned a new 5-connection pool on every HTTP request) with db.session.execute() using the shared app pool; also switch to sqlalchemy.text() with bound parameters to fix SQL injection via timezone arguments
- settings.py: add pool_pre_ping=True so stale connections are validated before use, preventing "MySQL server has gone away" errors after idle periods
- celery_worker.py: call db.session.remove() in ContextTask finally block so connections are returned to the pool after every task regardless of outcome; previously connections leaked until CELERY_WORKER_MAX_TASKS_PER_CHILD recycled the process - assignment_search_enddate.py: replace per-request create_engine() (which spawned a new 5-connection pool on every HTTP request) with db.session.execute() using the shared app pool; also switch to sqlalchemy.text() with bound parameters to fix SQL injection via timezone arguments - settings.py: add pool_pre_ping=True so stale connections are validated before use, preventing "MySQL server has gone away" errors after idle periods
ionparticle
approved these changes
Mar 13, 2026
Member
ionparticle
left a comment
ionparticle
left a comment
There was a problem hiding this comment.
I would prefer the raw SQL queries to be refactored to ORM queries, but that can wait for the sqlalchemy upgrade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.