Fix/1059: Re-enable BE unit tests for CI#1069
Merged
Conversation
- If don't mock, it makes an actual HTTP call to `SAML_METADATA_URL`. Mock it to prevent our unit tests from making real HTTP calls. - It passes fine when running locally (`SAML_METADATA_URL=None`) but fails when running inside a container. - Fails because `https://samltest.id/saml/idp` no longer exists and therefore returns 410 Gone error.
ionparticle
approved these changes
Apr 7, 2026
| if: false # Temporarily disabled | ||
| strategy: | ||
| matrix: | ||
| python-version: [3.8] |
Member
There was a problem hiding this comment.
Should update to python 3.10 to match new Dockerfile. Otherwise, I think it's good to go. Feel free to merge anytime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1059
test_saml_metadataintest_login.pySAML_METADATA_URL. Mock it to prevent our unit tests from making real HTTP calls.SAML_METADATA_URL=None) but fails when running inside a container.[https://samltest.id/saml/idp](https://samltest.id/saml/idp%60) no longer exists and therefore returns 410 Gone error.test_create_attachmentintest_file.pypytestinstead ofnosetests