give guidance to reduce scope of constants #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyler-french
commented
Aug 1, 2024
sywhang
approved these changes
Aug 1, 2024
Contributor
sywhang
left a comment
sywhang
left a comment
There was a problem hiding this comment.
I'm fine with this change if we undo the header change. Thanks!
tyler-french
force-pushed
the
const-scope
branch
from
fa8dbc6 to
c036a5a
Compare
abhinav
reviewed
Aug 9, 2024
abhinav
reviewed
Aug 9, 2024
Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
abhinav
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #216 for more information.
This is just a draft, and more to start discussion to understand what the correct guidance here is.