Add WIP warnings around prom reporter #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
SokolAndrey
approved these changes
Feb 9, 2021
andrewmains12
force-pushed
the
amains/prom/warning
branch
from
a5955d8 to
7520296
Compare
mway
reviewed
Feb 9, 2021
andrewmains12
force-pushed
the
amains/prom/warning
branch
from
7520296 to
063fc2d
Compare
As discussed with @alexeykudinkin and @SokolAndrey, we're not quite ready to have the prom reporter actively used by folks. It's already released (hard to undo), but we can at least give users a heads up for the time being. I figure we can probably remove these once we've addressed perf concerns and maybe done some baking of the lib within Uber.
andrewmains12
force-pushed
the
amains/prom/warning
branch
from
063fc2d to
bef7e66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @alexeykudinkin and @SokolAndrey, we're not quite ready to have the prom reporter actively used by folks. It's already released (hard to undo), but we can at least give users a heads up for the time being. I figure we can probably remove these once we've addressed perf concerns and maybe done some baking of the lib within Uber.