Skip to content

Conversation

@ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Jun 22, 2021

Some weird issue with istanbul, as usual

@ibgreen
Copy link
Collaborator Author

ibgreen commented Jun 22, 2021

@Avnerus If you rebase your PR should build again.

@ibgreen ibgreen requested a review from Pessimistress June 22, 2021 22:08
@ibgreen ibgreen merged commit 2ab4a71 into master Jun 22, 2021
@ibgreen ibgreen deleted the ib/fix-node-16-build branch June 22, 2021 22:08
ibgreen added a commit that referenced this pull request Jun 22, 2021
@Pessimistress
Copy link
Collaborator

Are you sure you should be checking in a 148k line file in .yarn?

@ibgreen
Copy link
Collaborator Author

ibgreen commented Jun 23, 2021

Hmm I tried using yarn policies to fix the version as I was having install issues. Didn't realize that it is storing the entire binary :-o. Good catch, I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants