Skip to content

Conversation

@ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Jun 23, 2021

Adds new flag to ocularrc.js: webpack.version.

Generates updated webpack config in this case.

Still haven't been able to get BrowserTestDriver working so still installing webpack 4.

@ilijapuaca

@ibgreen ibgreen requested a review from Pessimistress June 23, 2021 00:23
@ibgreen ibgreen merged commit 6bdeead into master Jun 23, 2021
@ibgreen ibgreen deleted the ib/webpack5 branch June 23, 2021 00:24
@coveralls
Copy link

Pull Request Test Coverage Report for Build 962570565

  • 17 of 31 (54.84%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-1.2%) to 71.639%

Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/dev-tools/src/configuration/get-webpack-config.js 10 16 62.5%
modules/dev-tools/node/test.js 7 15 46.67%
Files with Coverage Reduction New Missed Lines %
modules/dev-tools/node/test.js 1 31.82%
Totals Coverage Status
Change from base Build 962567400: -1.2%
Covered Lines: 266
Relevant Lines: 331

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants