New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add animal-sniffer to guard against Java 8 only APIs #264

Merged
merged 3 commits into from Oct 14, 2018

Conversation

Projects
None yet
2 participants
@shaishavgandhi05
Contributor

shaishavgandhi05 commented Oct 11, 2018

Description: Add animal-sniffer to guard against Java 8 only APIs

Resolves #261

Add animal-sniffer to guard against Java 8 only APIs
Signed-off-by: shaishavgandhi05 <shaishgandhi@gmail.com>
@hzsweers

This comment has been minimized.

Show comment
Hide comment
@hzsweers

hzsweers Oct 11, 2018

Collaborator

We do to need to configure which java version?

Collaborator

hzsweers commented Oct 11, 2018

We do to need to configure which java version?

@shaishavgandhi05

This comment has been minimized.

Show comment
Hide comment
@shaishavgandhi05

shaishavgandhi05 Oct 11, 2018

Contributor

It's here

I've added it as 1.7 since my understanding was that animal-sniffer will check if it compiles to Java 1.7. Since we don't want any Java8-only APIs, 1.7 would work.

Contributor

shaishavgandhi05 commented Oct 11, 2018

It's here

I've added it as 1.7 since my understanding was that animal-sniffer will check if it compiles to Java 1.7. Since we don't want any Java8-only APIs, 1.7 would work.

@hzsweers

This comment has been minimized.

Show comment
Hide comment
@hzsweers

hzsweers Oct 12, 2018

Collaborator

Ah gotcha, missed that on the first read. Could we try a sample commit in this branch to confirm it fails the CI checks? Then we can revert the commit after and merge if it works as expected 👍

Collaborator

hzsweers commented Oct 12, 2018

Ah gotcha, missed that on the first read. Could we try a sample commit in this branch to confirm it fails the CI checks? Then we can revert the commit after and merge if it works as expected 👍

Add Java 8 Only API: ZonedDateTime
Signed-off-by: shaishavgandhi05 <shaishgandhi@gmail.com>
@shaishavgandhi05

This comment has been minimized.

Show comment
Hide comment
@shaishavgandhi05

shaishavgandhi05 Oct 13, 2018

Contributor

Pushed a commit that fails the check. Let me know if it looks good and I can revert it.

Contributor

shaishavgandhi05 commented Oct 13, 2018

Pushed a commit that fails the check. Let me know if it looks good and I can revert it.

@hzsweers

This comment has been minimized.

Show comment
Hide comment
@hzsweers

hzsweers Oct 13, 2018

Collaborator

Perfect! Looks good, let’s revert and we can merge

Collaborator

hzsweers commented Oct 13, 2018

Perfect! Looks good, let’s revert and we can merge

@shaishavgandhi05

This comment has been minimized.

Show comment
Hide comment
@shaishavgandhi05

shaishavgandhi05 Oct 14, 2018

Contributor

Done!

Contributor

shaishavgandhi05 commented Oct 14, 2018

Done!

@hzsweers

Thanks!

@hzsweers hzsweers merged commit 327da40 into uber:master Oct 14, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment