Move BaseTileLayer to geo-layers #4232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Feb 5, 2020
| - Default: `null` | ||
|
|
||
|
|
||
| ##### `strategy` (Enum, optional) |
There was a problem hiding this comment.
Not a strong opinion here, but perhaps refinementStrategy, tileRefinementStrategy tileSelectionStrategy etc might be a bit more clear than just strategy?
| - Default: `'best-available'` | ||
|
|
||
|
|
||
| ##### `tileToBoundingBox` (Function, optional) |
There was a problem hiding this comment.
- I am wondering if there could be a
tilesetprop here, so that the user can pass in a Tileset2D instance? - And if so, several of the other advanced customization props could be specified (also, or exclusively) on the Tileset2D class
- A lot of the customization for e.g. non-geospatial user cases would happen by users subclassing and redefining Tileset2D
- If there was sufficient API alignment between tileset2D and tileset3D we might in the future just have a single TileLayer (essentially joining TileLayer and Tile3DLayer). This would of course require a serious generalization effort, so would come later, if at all.
There was a problem hiding this comment.
I like this idea. It would require the Tileset2D class to be better defined and fully documented. I will open a follow-up PR for this.
There was a problem hiding this comment.
+1, I was just hacking around. I wanted to load a static set of tiles at a specific zoom level to work around the low performance of the TerrainLayer and implement a make-shift terrain geofence for a user. Any ideas?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ilan-gold
See discussion in #4230 (comment)
Change List
BaseTileLayerback togeo-layers