Skip to content

Conversation

@isaacbrodsky
Copy link
Collaborator

This incorporates the change "Fixed constraints of vertex longitudes (uber/h3#213)"

Copy link
Contributor

@nrabinowitz nrabinowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need a CHANGELOG update?

Copy link
Contributor

@nrabinowitz nrabinowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@coveralls
Copy link

coveralls commented May 3, 2019

Pull Request Test Coverage Report for Build 156

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 99.461%

Files with Coverage Reduction New Missed Lines %
src/main/java/com/uber/h3core/H3Core.java 1 99.28%
Totals Coverage Status
Change from base Build 152: -0.3%
Covered Lines: 369
Relevant Lines: 371

💛 - Coveralls

@nrabinowitz
Copy link
Contributor

...how did we drop coverage by adding tests? 😕

@isaacbrodsky
Copy link
Collaborator Author

The problem is we no longer have a case that succeeds at maxUncompactSize but fails at uncompact, so the branch for error is no longer hit: https://coveralls.io/builds/23177618/source?filename=src%2Fmain%2Fjava%2Fcom%2Fuber%2Fh3core%2FH3Core.java#L911 This is because of the change mentioned in uber/h3#229

@isaacbrodsky isaacbrodsky merged commit 15ad9f4 into uber:master May 20, 2019
@isaacbrodsky isaacbrodsky deleted the bump-3.4.3 branch May 20, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants